Yaniv Bronhaim has posted comments on this change. Change subject: utils: Raise detectable error if termination fail ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/65325/6/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 752: proc.kill() Line 753: proc.wait() Line 754: except Exception as e: Line 755: raise TerminatingFailure(proc.pid, e) Line 756: why not to raise the original exception ? Line 757: Line 758: def get_selinux_enforce_mode(): Line 759: """ Line 760: Returns the SELinux mode as reported by kernel. -- To view, visit https://gerrit.ovirt.org/65325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cfa5434ce011b9185550884233b5b233026d13c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
