Irit Goihman has posted comments on this change. Change subject: jsonrpc: introduce new client ......................................................................
Patch Set 10: Verified+1 (3 comments) https://gerrit.ovirt.org/#/c/64502/8/lib/vdsm/client.py File lib/vdsm/client.py: Line 43: cli.call(method, args, timeout) Line 44: Line 45: Examples: Line 46: Line 47: cli.call('Host.getVMList') > This is not very clear, lets show an example request with complex parameter Done Line 48: Line 49: result: Line 50: [u'd7207614-38e3-43c4-b8f2-6086867d0a84', Line 51: u'2c73bed5-cd2a-4d01-9095-97c0d71c831b'] https://gerrit.ovirt.org/#/c/64502/9/lib/vdsm/client.py File lib/vdsm/client.py: Line 95: "display": "qxl", "maxvcpus": "16", "maxmemslots": 16}, Line 96: "vmid": "d7207614-38e3-43c4-b8f2-6086867d0a84"})) Line 97: Line 98: ClientError will be raised in case of a protocol error: Line 99: > args is optional now (good), but you are using mutable default argument, me Done Line 100: vdsm.client.ClientError: Error sending request: [Errno 111] Line 101: Connection refused Line 102: Line 103: TimeoutError will be raised when preconfigured amount of time has passed with Line 105: Line 106: vdsm.client.TimeoutError: timeout waiting for a response Line 107: Line 108: ServerError will be raised if the command encountered execution error: Line 109: > I think we need to introduce a Timeout error, otherwise the user cannot tel Done Line 110: vdsm.client.ServerError: Vdsm request failed Line 111: (code=4, message=Virtual machine already exists) Line 112: Line 113: -- To view, visit https://gerrit.ovirt.org/64502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
