Yaniv Bronhaim has posted comments on this change. Change subject: utils: Wait for terminated process ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65324/5/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 737: try: Line 738: if proc.poll() is None: Line 739: logging.debug('Terminating process pid=%d' % proc.pid) Line 740: proc.kill() Line 741: proc.wait() Dan said that he doesn't understand my comment - we invented this context to cover proc object in such way that won't leave zombies if the context exists in the middle - for safety to avoid depending on the old death signal that we had. Now, instead of just trying to kill the process and "reap" it, the context won't continue until the process exits... at least for me it is not the expected behavior. however, we still don't use it so we can change it if that way you see more usages for this context Line 742: except Exception: Line 743: logging.exception('Failed to kill process %d' % proc.pid) Line 744: Line 745: -- To view, visit https://gerrit.ovirt.org/65324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida04e2c7ba092efdc2927ed9f460b0098ba2ad94 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
