Francesco Romani has posted comments on this change. Change subject: virt: Stop guest agent before switching to post-copy ......................................................................
Patch Set 9: Code-Review+1 (1 comment) minor comment, not worth delaying a +1 https://gerrit.ovirt.org/#/c/64145/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1189: # will never reach this point and no event will be emitted. Line 1190: event_data = self._getExitedVmStats() Line 1191: except DoubleDownError: Line 1192: pass Line 1193: if not self.post_copy: I'm not sure I like using this in a boolean context. Reads nice and seems safe, but if self.post_copy == PostCopyPhase.NONE: ... is more explicit. I think here (inside Vm class) explicitness is a bit more important, but this is just a suggestion, not a requirement. Line 1194: try: Line 1195: self.guestAgent.stop() Line 1196: except Exception: Line 1197: pass -- To view, visit https://gerrit.ovirt.org/64145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd855ee36847b293009ac35d8d03b01521aaace8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
