Martin Polednik has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/65590/7/tests/periodicTests.py
File tests/periodicTests.py:

PS7, Line 269: self.assertEqual(_Visitor.VMS.get(vm_id), None)
You're asking for apples and getting oranges: skip_ids are NOT the vm ids. 

self.assertEqual(_Visitor.VMS.get(_fake_vm_id(vm_id)), None)

To compare same (semantic) objects.


-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to