Francesco Romani has posted comments on this change. Change subject: vm: check stats timeout only for monitorable VMs ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/65727/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4683: Line 4684: def _setUnresponsiveIfTimeout(self, stats, stats_age): Line 4685: if self.isMigrating(): Line 4686: return Line 4687: if not self._monitorable: > Don't we have still a minor race here (I'm not sure, just asking)? May it h I think such race exists, and since preventing it looks feasible, let's try to do so. Line 4688: return Line 4689: # we don't care about decimals here Line 4690: if stats_age < config.getint('vars', 'vm_command_timeout'): Line 4691: return -- To view, visit https://gerrit.ovirt.org/65727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
