Martin Polednik has posted comments on this change. Change subject: caps: report realtime kernel status ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/65715/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS1, Line 6495: with RT_PREEMPT enabled > I wonder if you need to document those details here. This is not really about computation of the field, but slightly-more-than-required explanation what the value is. The reason for the amount of care is to avoid any API consumer to consider the value as final statement on RT operation status -- it's only a little piece of the puzzle. Why mentioning the kernel config option of just saying "realtime kernel blah blah"? Mostly due to RT wiki, where RT_PREEMPT google query will most likely return https://rt.wiki.kernel.org/index.php/RT_PREEMPT_HOWTO which is one of the best sources of information regarding RT up to date. PS1, Line 6497: type > I think you may want to use: "True!" https://gerrit.ovirt.org/#/c/65715/1/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: PS1, Line 261: dict > why dict() and not literal syntax? Just curious, I don't think this has any I'm afraid the only reason is that it was this way since I remember the code. If you feel that it's improvement I can change the syntax in the patch. -- To view, visit https://gerrit.ovirt.org/65715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
