Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/65760

to review the following change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
......................................................................

net: edit nic detached from bridge but still attached to a vlan

Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Signed-off-by: Petr Horáček <phora...@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1372798
Reviewed-on: https://gerrit.ovirt.org/65231
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
Continuous-Integration: Jenkins CI
(cherry picked from commit 0970a9e90bc229d1fc95210153aacf564353516d)
Reviewed-on: https://gerrit.ovirt.org/65232
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/65760/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index f49693a..f04a7f3 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -281,6 +281,11 @@
             if set_mtu is not None:
                 ipwrapper.linkSet(nic.name, ['mtu', str(set_mtu)])
 
+            # If the nic was bridged, we must remove BRIDGE parameter from its
+            # ifcfg configuration file.
+            if nic.bridge:
+                self.configApplier.dropBridgeParameter(nic.name)
+
     def _getFilePath(self, fileType, device):
         return os.path.join(NET_CONF_DIR, '%s-%s' % (fileType, device))
 


-- 
To view, visit https://gerrit.ovirt.org/65760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to