Edward Haas has posted comments on this change. Change subject: storage: prepare iscsi for IPv6 targets ......................................................................
Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/65696/11/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: PS11, Line 59: getTargetString > > How about 'portal_join'? The return value is assigned to 'portalStr', that is why I proposed portal. I guess target_join or targetJoin is also fine. I do not know what convention storage is using, or what they prefer to have, leaving that to this code maintainers. PS11, Line 71: str(portal.port)), > Why not? hosttail_join wants the port number as a string, for this reason t I just asked if the whole hosttail_join call can be on the same line. return "%s%s%s" % (hosttail_join(portal.hostname, str(portal.port)), tpgtStr, iqnStr) -- To view, visit https://gerrit.ovirt.org/65696 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dhol...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dominik Holler <dhol...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
