Irit Goihman has posted comments on this change.

Change subject: stomp: simplified client
......................................................................


Patch Set 13: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/59151/10/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 603:     """
Line 604:     reactor = Reactor()
Line 605: 
Line 606:     def start():
Line 607:         thread = concurrent.thread(reactor.process_requests,
> this also doesn't change anything. daemon=True is the deafult in out concur
it's a rebase problem
Line 608:                                    name='Client %s:%s' % (host, port))
Line 609:         thread.start()
Line 610: 
Line 611:     client = StompClient(utils.create_connected_socket(host, port, 
sslctx),


-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to