From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Run the tests with tox ...................................................................... build: Run the tests with tox Run the tests via tox, installing the correct version of nose in a virtual environment. Since correct version is nose is always available, the warning about nose version is not needed now. By default, tox uses random PYTHONAHSHSEED on each run. This exposes bad code assuming that unordered things are ordered. Turns out we have some tests with this issue. To keep the build working, this option is disabled now (PYTHONHASHSEED = 0). We should remove this option when the bad tests are fixed. Change-Id: I245a171940a5e869fd719a6410024ee77e8ad86c Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/65404 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Irit Goihman <[email protected]> Reviewed-by: Edward Haas <[email protected]> Reviewed-by: Piotr Kliczewski <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M Makefile.am M automation/check-patch.sh M tox.ini 3 files changed, 15 insertions(+), 8 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I245a171940a5e869fd719a6410024ee77e8ad86c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
