From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: reroute messages to different process ...................................................................... Patch Set 3: Code-Review-1 (2 comments) This is quite important extension to vdsm's stomp protocol logic. I don't know if the "redirect" header is part of stomp rfc (if it is please refer to it and add a link to the description). In any case, please add detailed explanation about the implementation - in each subscription you hold a list of redirects, how you use this list and when. it will be easier to understand your design here https://gerrit.ovirt.org/#/c/65846/3/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 255: except Exception: Line 256: # let json server process issue Line 257: pass Line 258: for request in requests: Line 259: dispatcher.connection.handleMessage(request) how handling more than one request is related to redirects? maybe it is worth separate patch? Line 260: Line 261: def _handle_destination(self, dispatcher, req_dest, frame, request): Line 262: """ Line 263: We could receive single message or batch of messages. We need https://gerrit.ovirt.org/#/c/65846/3/tests/stompAdapterTests.py File tests/stompAdapterTests.py: Line 305: adapter.handle_frame(TestDispatcher(adapter), frame) Line 306: Line 307: data = adapter.pop_message() Line 308: self.assertIsNot(data, None) Line 309: request = JsonRpcRequest.fromRawObject(data) is it related to the patch? Line 310: self.assertEquals(request.method, 'Host.getAllVmStats') Line 311: self.assertTrue(len(ids) == 1) Line 312: Line 313: def test_send_no_destination(self): -- To view, visit https://gerrit.ovirt.org/65846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I622cb7f3b39a19314b7de4c325a62fa47faeaa4d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: Stuart Gott <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
