From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net: let users override Engine's default route ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/66127/3/lib/vdsm/network/canonicalize.py File lib/vdsm/network/canonicalize.py: Line 133: data['defaultRoute'] = False Line 134: Line 135: custom_default_route = utils.rget(data, ('custom', 'default_route')) Line 136: if custom_default_route is not None: Line 137: data['defaultRoute'] = utils.tobool(custom_default_route) setting False on a network that has DNS, would make it impossible to restore the network on boot. DNS is not yet in Engine, but it can already be on vdsm side. Line 138: Line 139: Line 140: def _canonicalize_nameservers(data): Line 141: if 'nameservers' not in data: -- To view, visit https://gerrit.ovirt.org/66127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf392ea05e1e39acbf1b74a7a31acda9e750b36e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Germano Veit Michel <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
