Dan Kenigsberg has posted comments on this change.

Change subject: The return of super vdsm tests
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/supervdsm.py
Line 126:         # permissions to read those files.
Line 127:         superVdsmCmd = [pypathCmd, constants.EXT_PYTHON, SUPERVDSM,
Line 128:                         self._authkey, str(os.getpid()),
Line 129:                         self.pidfile, self.timestamp, self.address,
Line 130:                         str(os.getuid())]
however, by default, sudo=True ignores env.
Line 131:         misc.execCmd(superVdsmCmd, sync=False, sudo=True)
Line 132:         sleep(2)
Line 133: 
Line 134:     def kill(self):


--
To view, visit http://gerrit.ovirt.org/9278
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52e935662633601ce85150171c37fbf7c6196c15
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to