From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: autoconf: made vdsmrepo customizable ...................................................................... Patch Set 5: Code-Review-1 (6 comments) https://gerrit.ovirt.org/#/c/67248/5//COMMIT_MSG Commit Message: PS5, Line 9: accept accepts PS5, Line 14: rhel Fedora's https://gerrit.ovirt.org/#/c/67248/5/automation/build-artifacts.sh File automation/build-artifacts.sh: Line 9: cp $PWD/automation/index.html "$EXPORTS" Line 10: Line 11: # autogen may already have been executed by check-patch.sh Line 12: if [ ! -f Makefile ]; then Line 13: ./autogen.sh --system --enable-hooks --enable-vhostmd --with-data-center='/rhev/data-center/' I love short lines, even in Bash Line 14: fi Line 15: Line 16: make Line 17: https://gerrit.ovirt.org/#/c/67248/5/configure.ac File configure.ac: Line 397 Line 398 Line 399 Line 400 Line 401 these seem inadvertant changes. please rebase on top of current master. PS5, Line 243: data-center "data-center" is an ambiguous name. I suggest to call this "storage-repo" Line 267: AC_SUBST([vdsmbackupdir], ['${vdsmlogdir}/backup']) Line 268: AC_SUBST([vdsmexecdir], ['${libexecdir}/vdsm']) Line 269: AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks']) Line 270: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm']) Line 271: AC_SUBST([vdsmrepo], ['${with_data_center']) missing closing brace Line 272: AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm']) Line 273: AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo']) Line 274: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool']) Line 275: AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators']) -- To view, visit https://gerrit.ovirt.org/67248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2498e473a11a180254326c6ad9ed9b117bdaec7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
