From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: WIP: containers: add docker network provider plugin ...................................................................... Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/67229/5/lib/vdsm/compat.py File lib/vdsm/compat.py: Line 46: Line 47: import SocketServer as socketserver Line 48: socketserver Line 49: Line 50: from BaseHTTPServer import BaseHTTPRequestHandler please use six.moves.BaseHTTPServer instead of reinventing it. Line 51: BaseHTTPRequestHandler Line 52: else: Line 53: from subprocess import Popen as CPopen Line 54: CPopen # make pyflakes happy -- To view, visit https://gerrit.ovirt.org/67229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5557eb09964bd55194d7de1610f056d67745c20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
