From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures ...................................................................... Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/65294/11/tests/utils_test.py File tests/utils_test.py: Line 92: Line 93: def tearDown(self): Line 94: if self.proc_poll() is None: Line 95: self.proc_kill() Line 96: self.proc_wait() I'd love to change this mocking to be with python mock Line 97: Line 98: def test_process_running(self): Line 99: with utils.terminating(self.proc): Line 100: self.assertIsNone(self.proc_poll()) Line 154: self.assertEqual(type(e.exception.error), ExpectedFailure) Line 155: Line 156: # Note: We cannot check return code since AsyncProc.returncode is a Line 157: # property calling poll(). The return code here may be None or -9, Line 158: # depeending on timing. double e Line 159: Line 160: Line 161: class ExpectedFailure(Exception): Line 162: pass -- To view, visit https://gerrit.ovirt.org/65294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8674c9c3c2118041c74213cd8ce0d383086d6cbf Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
