From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: py3: make some of network/tc_test pass ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/63198/2/tests/network/tc_test.py File tests/network/tc_test.py: Line 29: Line 30: from nose.plugins.attrib import attr Line 31: Line 32: import six Line 33: from six.moves import zip_longest > This is bad trend, replacing something that clearly returns an iterator to it is only a matter of choice: whether you stick with the past naming (in py2 it's a list) or embrace the future (in py3 it is an iterator). six opted for the latter approach, which I prefer to keep here. Line 34: Line 35: from vmfakecon import Connection Line 36: from testlib import (VdsmTestCase as TestCaseBase, permutations, Line 37: expandPermutations) -- To view, visit https://gerrit.ovirt.org/63198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I544446358e611a0507aad7d7df4ab6c57ad5bdf0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
