From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: tests: Terminate running jobs on exit ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/67799/2/tests/py-watch File tests/py-watch: PS2, Line 2: python is there anything python-specific in this script? Line 6: Line 7: watched_pid=$1 Line 8: timeout=$2 Line 9: Line 10: function terminate_jobs { blechs, it seem that huponexit cannot be turned on for non-interactive shells (why?) so that's the only way to kill sleep. Line 11: running_jobs=$(jobs -pr) Line 12: if [ -n "$running_jobs" ]; then Line 13: kill $running_jobs Line 14: fi -- To view, visit https://gerrit.ovirt.org/67799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28a1188ad3ddc6af76263281b63b6574c8f4f2fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Barak Korren <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
