From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has posted comments on this change.
Change subject: api: move vdsmapi to lib ...................................................................... Patch Set 1: Code-Review-1 (6 comments) https://gerrit.ovirt.org/#/c/67835/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-12-05 15:42:29 +0100 Line 6: Line 7: api: move vdsmapi to lib Line 8: Line 9: say what you keep under api. what is now installed as part of vdsm or vdsm-python (im not sure) and what is installed as part of vdsm-api - the commit message will be the documentation regarding this arrangement. Line 10: Bug-Url: https://bugzilla.redhat.com/1376116 Line 11: Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc https://gerrit.ovirt.org/#/c/67835/1/lib/vdsm/rpc/Bridge.py File lib/vdsm/rpc/Bridge.py: Line 24: import API Line 25: import yajsonrpc Line 26: from vdsm.api import vdsmapi Line 27: Line 28: from vdsm.common.exception import VdsmException put the import after the separation line Line 29: from vdsm.config import config Line 30: from vdsm.network.netinfo.addresses import getDeviceByIP Line 31: Line 32: https://gerrit.ovirt.org/#/c/67835/1/tests/schemaValidationTest.py File tests/schemaValidationTest.py: Line 1: # Line 2: # Copyright 2014-2015 Red Hat, Inc. probably someone will ask you to update the year as well Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 27: except ImportError: Line 28: _glusterEnabled = False Line 29: Line 30: from vdsm.rpc import Bridge Line 31: from vdsm.api import vdsmapi order Line 32: from testlib import Sigargs Line 33: from testlib import VdsmTestCase as TestCaseBase Line 34: Line 35: from contextlib import contextmanager https://gerrit.ovirt.org/#/c/67835/1/tests/vmApiTests.py File tests/vmApiTests.py: Line 1: # Line 2: # Copyright 2014 Red Hat, Inc. year? I hate this comment in reviews.. I wish we could stop updating the year Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/67835/1/vdsm.spec.in File vdsm.spec.in: Line 1567: %doc lib/api/vdsm-api.html Line 1568: %dir %{python_sitelib}/%{vdsm_name} Line 1569: %dir %{python_sitelib}/%{vdsm_name}/api Line 1570: %dir %{python_sitelib}/%{vdsm_name}/rpc Line 1571: %{python_sitelib}/%{vdsm_name}/api/*.py* you don't leave under this dir any py filrs.. why to add this line? Line 1572: %{python_sitelib}/%{vdsm_name}/rpc/vdsm-api.yml Line 1573: %{python_sitelib}/%{vdsm_name}/rpc/vdsm-events.yml Line 1574: %if ! 0%{?with_gluster_mgmt} Line 1575: %exclude %{python_sitelib}/%{vdsm_name}/rpc/vdsm-api-gluster.yml -- To view, visit https://gerrit.ovirt.org/67835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
