From Yaniv Bronhaim <[email protected]>:

Yaniv Bronhaim has posted comments on this change.

Change subject: automation: remove createrepo stage in check-merged.sh
......................................................................


Patch Set 6: Code-Review+2

(4 comments)

https://gerrit.ovirt.org/#/c/67356/5//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-11-27 11:58:41 +0200
Line 4: Commit:     Nadav Goldin <[email protected]>
Line 5: CommitDate: 2016-12-02 13:45:10 +0200
Line 6: 
Line 7: automation: remove createrepo stage in check-merged.sh
quite general title
Line 8: 
Line 9: Remove the use of 'createrepo' in check-merged.sh, instead let lago
Line 10: handle the repo creation. The RPMs in the 'custom-source' parameter
Line 11: (which are the ones built pre patch) will be preferred over all other


Line 12: artifacts found in reposync.config. This aligns with how OST operates.
Line 13: Also changing 'reposync-config.repo.tpl' to a static file and excluding
Line 14: conflicting package(ovirt-release*).
Line 15: 
Line 16: Change-Id: I992ce9a8a822545140d27501d67e0e7bfa3f046d
try to keep 70 chars in line


Line 14: conflicting package(ovirt-release*).
Line 15: 
Line 16: Change-Id: I992ce9a8a822545140d27501d67e0e7bfa3f046d
Line 17: Signed-off-by: Nadav Goldin <[email protected]>
Line 18
I prefer links to the patches


Line 15: 
Line 16: Change-Id: I992ce9a8a822545140d27501d67e0e7bfa3f046d
Line 17: Signed-off-by: Nadav Goldin <[email protected]>
Line 18
Line 19
must split the fixes to patches..


-- 
To view, visit https://gerrit.ovirt.org/67356
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I992ce9a8a822545140d27501d67e0e7bfa3f046d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nadav Goldin <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Irit Goihman <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to