From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: py3: fix remaining references to monitor.MonitorError as iterable ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64929/1/init/wait_for_ipv4s File init/wait_for_ipv4s: Line 50: ipless_devs.remove(dev_name) Line 51: if not ipless_devs: Line 52: return Line 53: except monitor.MonitorError as e: Line 54: if e.args[0] == monitor.E_TIMEOUT: > You are probably right, though I don't know if 'reason' fits a simple code With your permission, I suggest to postpone larger renaming, and take only this support as it is. Line 55: sys.stderr.write('IP addresses has not been caught within the ' Line 56: 'given timeout.\n') Line 57: else: Line 58: raise -- To view, visit https://gerrit.ovirt.org/64929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic991c1a017f09431d4b38f58e529d0a6ec45a896 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
