From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: virt: Add virt-sysprep support ...................................................................... Patch Set 5: (1 comment) Francesco, Michal: the storage-side problem is not only about the sysprepped volume. We CANNOT modify image metadata (e.g. SHAREABLE) from HSM. This defies the premise of Vdsm storage. Only SPM is allowed to do that, because only SPM knows that no other host is making a conflicting modification for the same storage. Regardless of the technical issue, there's a process-wise issue. We must not make any change to vdsm/storage/sdm/api/* if its maintainer objects. https://gerrit.ovirt.org/#/c/68025/5/vdsm/virt/seal.py File vdsm/virt/seal.py: PS5, Line 45: nested > I know about deprecation of nested(). But we cannot use multiple manager fo I know about the existing usage of nested. I dislike it, and hence asked if it would be possible to avoid it. I now see that we do not have python-contextlib2 in downstream el7. Maybe you can try to add it there? -- To view, visit https://gerrit.ovirt.org/68025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I676631d87ac3a7845be76a57a08c89ed117a90a6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
