From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer: handle arguments with argparse ...................................................................... Patch Set 9: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/68776/9/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 324: Line 325: def option_parser(): Line 326: parser = argparse.ArgumentParser() Line 327: parser.add_argument('--sockfile', dest='sockfile', required=True, Line 328: help="socket file path") lets make it easier and set a default to /var/run/vdsm/svdsm.sock .. if we already here :\ Line 329: parser.add_argument('--pidfile', dest='pidfile', default=None, Line 330: help="pid file path") Line 331: return parser Line 332: -- To view, visit https://gerrit.ovirt.org/68776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab6c19d628adc38b7c76c4fc2bba1cc422dbbd5a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
