ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [1/3] Add API definitions.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 4869: # Since 4.11.0
Line 4870: ##
Line 4871: {'type': 'updateVmDeviceParams',
Line 4872: 'data': {'type': 'str', 'network': 'str',
Line 4873: 'linkState': 'NetworkInterfaceState', 'alias': 'str',
'promisc': ''}}
Please align the descriptions so they all start at the same column. See the
rest of the file for how it's done. Sorry to be pedantic, but the rest of the
file looks so nice :)
Line 4874:
Line 4875: ##
Line 4876: # @VM.updateVmDevice:
Line 4877: #
Line 4878: # Update the status of a VM's device.
Line 4879: #
Line 4880: # @vmId: The UUID of the VM to modify
Line 4881: #
Line 4882: # @params: The VM UUID and device information.
alignment.
Line 4883: #
Line 4884: # Returns:
Line 4885: # The VM definition, as updated
Line 4886: #
--
To view, visit http://gerrit.ovirt.org/9560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8352f237dbe0229dff368f7c1dfa4f5f8fc766
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
