From Dan Kenigsberg <[email protected]>:

Dan Kenigsberg has posted comments on this change.

Change subject: virt: improving readability of duri/muri formation
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/68770/10/lib/vdsm/virt/migration.py
File lib/vdsm/virt/migration.py:

Line 444:             else:
Line 445:                 transport = 'tcp'
Line 446:             duri = 'qemu+{}://{}/system'.format(transport, 
self.remoteHost)
Line 447: 
Line 448:             dstqemu = 
self._vm.conf['_migrationParams'].get('dstqemu', self.remoteHost)
holy 80 column rule broken
Line 449:             muri = 'tcp://{}'.format(dstqemu)
Line 450: 
Line 451:             self._vm.log.info('starting migration to %s '
Line 452:                               'with miguri %s', duri, muri)


-- 
To view, visit https://gerrit.ovirt.org/68770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib068cb807d8224974460d6cadf8ceda2f55468bf
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to