From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net: Aggregate network initializations under one roof ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/69198/2/lib/vdsm/supervdsm_server.py File lib/vdsm/supervdsm_server.py: Line 66: from vdsm.storage.iscsi import getDevIscsiInfo as _getdeviSCSIinfo Line 67: from vdsm.storage.iscsi import readSessionInfo as _readSessionInfo Line 68: from vdsm.supervdsm import _SuperVdsmManager Line 69: Line 70: from vdsm.network import initializer as network_initializer but we know that we intend to kick dhclient_monitor out of supervdsm, so we are about to need to initilize these two network things independently. why merge them temporarily? Line 71: Line 72: from vdsm.storage.multipath import getScsiSerial as _getScsiSerial Line 73: from vdsm.storage import multipath Line 74: from vdsm.constants import METADATA_GROUP, \ -- To view, visit https://gerrit.ovirt.org/69198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90e002bdb029f796efeab2ff5e89234b8ce2200f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
