From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: net: remove sourceroute dependency on the configurators ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/69380/2/lib/vdsm/network/sourceroute.py File lib/vdsm/network/sourceroute.py: Line 146: rules += [r for r in allRules if r.source == network] Line 147: Line 148: return rules Line 149: Line 150: def config_current(self): how about get_current_config? config_current sounds like an action. Line 151: rules = self._getRules(self.device) or () Line 152: table = self._getTable(rules) if rules else () Line 153: routes = self._getRoutes(table) if table else () Line 154: return routes, rules, self.device -- To view, visit https://gerrit.ovirt.org/69380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3bd18eaab5afc43cebde5cb6b43d106ba6a2ccf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgold...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
