From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Check changed modules in check-patch ...................................................................... Patch Set 9: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/69450/9/Makefile.am File Makefile.am: Line 103: $(NULL) Line 104: Line 105: .PHONY: pylint-diff Line 106: pylint-diff: tox Line 107: modules=`git diff-tree --no-commit-id --name-only -r HEAD | egrep '\.py$$'`; \ hmm, unlike the pylint target, this one checks changes in test files. Line 108: if [ -n "$$modules" ]; then tox -e pylint $$modules; fi Line 109: Line 110: .PHONY: flake8 Line 111: flake8: tox -- To view, visit https://gerrit.ovirt.org/69450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia458909a300c8555a84f3d7f1f8a410c0856e444 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
