From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: concurrent: Accept a logger instead of logger name
......................................................................


concurrent: Accept a logger instead of logger name

Accepting a logger is easier for the callers (all code is passing
log.name), more robust (now way to fail getting the logger), and
easier to test (can use fake logger to check logged messages).

Change-Id: I6b48182ec138a5b69dc502d7dc46da5781b1bc02
Signed-off-by: Nir Soffer <nsof...@redhat.com>
---
M lib/vdsm/concurrent.py
M lib/vdsm/executor.py
M lib/vdsm/libvirtconnection.py
M lib/vdsm/rpc/bindingxmlrpc.py
M lib/vdsm/schedule.py
M lib/vdsm/xmlrpc.py
M vdsm/storage/fc-scan
M vdsm/storage/hsm.py
M vdsm/storage/monitor.py
M vdsm/storage/sp.py
M vdsm/storage/storage_mailbox.py
11 files changed, 17 insertions(+), 16 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/69812
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b48182ec138a5b69dc502d7dc46da5781b1bc02
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to