From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has submitted this change and it was merged.
Change subject: sp: Fix attaching of live storage domain ...................................................................... sp: Fix attaching of live storage domain When attaching a live storage domain, like the hosted engine storage domain, the host id is already acquired, and must not be released after attaching the domain. Releasing the host id will cause sanlock to expire the leases on this domain and kill the hosted engine VM, holding a volume lease on this domain. We already had protection for live storage domain monitored by vdsm. However after restarting vdsm (e.g. by host-deploy), there is a window where vdsm does not know about the hosted engine storage domain, and if engine was trying to auto-import the hosted engine storage domain at this point vdsm was acquiring and releasing the host id, killing the hosted engine VM. Change-Id: Icf1165972fb0c328ef49852674e878617291fc36 Bug-Url: https://bugzilla.redhat.com/1409112 Signed-off-by: Nir Soffer <nsof...@redhat.com> (cherry picked from commit b9907afc901a0a5f17bbd4cef1b706d9d46cbe6f) --- M vdsm/storage/sp.py 1 file changed, 19 insertions(+), 11 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, but someone else must approve; Passed CI tests Simone Tiraboschi: Verified Yaniv Bronhaim: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf1165972fb0c328ef49852674e878617291fc36 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
