From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix integration tests ...................................................................... Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/55871/7//COMMIT_MSG Commit Message: Line 7: tests: fix integration tests Line 8: Line 9: This patch fixes an issue with integration tests which are not part of Line 10: general build process. We use to use __getattr__ method but we replaced Line 11: it with dispatch not to swap '.' with '_'. sorry, I do not understand how the commit message relates to the patch. Which integration test failed? how? does it pass now? Why isn't it in `make check`? can we place it in automation/check-merged? Line 12: Line 13: Line 14: Related-To: https://gerrit.ovirt.org/53472 Line 15: Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd -- To view, visit https://gerrit.ovirt.org/55871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
