From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: vm: Log device __repr__ instead of name ...................................................................... Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/69351/10/vdsm/virt/vmdevices/network.py File vdsm/virt/vmdevices/network.py: Line 315: nicDev['network'] = network Line 316: vm.conf['devices'].append(nicDev) Line 317: Line 318: def __repr__(self): Line 319: # Not sure that name is always available, using the attributes required could you add getattr(self, 'name', None) just in case someone liked seeing the nic "name" in the log? Line 320: # in getXML. Line 321: return ('<Interface type={self.device}, mac={self.macAddr} ' -- To view, visit https://gerrit.ovirt.org/69351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I666e13cf3c58c980e4291b7903220a7551e10f85 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
