From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce bond properties and refactoring options handling ...................................................................... Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/71024/3/lib/vdsm/network/link/bond/sysfs_options.py File lib/vdsm/network/link/bond/sysfs_options.py: PS3, Line 102: e no need to change this to lowercase but explaning the new args could be helpful (None in one means everything, and in the other - nothing). -- To view, visit https://gerrit.ovirt.org/71024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f9fe408dabb7009e07cc487d04f32b12b0322e6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dominik Holler <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
