From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net: modify VF MAC addresses on creation to a valid address ...................................................................... Patch Set 30: (1 comment) https://gerrit.ovirt.org/#/c/71029/30/lib/vdsm/network/api.py File lib/vdsm/network/api.py: PS30, Line 107: TARGET_MAC > https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variabl I'm not sure that pep8 says that now function-level constants are allowed. Anyway, I like keeping ALL CAPS here. -- To view, visit https://gerrit.ovirt.org/71029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
