Dan Kenigsberg has posted comments on this change.
Change subject: tests: Cleanup apiTests exception handling
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/apiTests.py
Line 217: raise ProtocolError("Unable to read response body: %s", e)
Line 218: if len(data) != msgLen:
Line 219: raise ProtocolError("Response body length mismatch")
Line 220: return json.loads(data)
Line 221: sock.close()
correct. with closing(socket.socket()) would have been in place. I did not
notice that the "finally" clause was dropped.
Line 222:
Line 223: def testPing(self):
Line 224: self.clearAPI()
Line 225: self.programAPI("testPing")
--
To view, visit http://gerrit.ovirt.org/9499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I818e5e7b8dd0a1abad94deb65e32c1d76225b839
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
