From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: stop detection ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/72740/2//COMMIT_MSG Commit Message: Line 4: Commit: Piotr Kliczewski <[email protected]> Line 5: CommitDate: 2017-02-21 13:03:53 +0100 Line 6: Line 7: xmlrpc: stop detection Line 8: I like the patch, but please explain it better in the commit message. I6b6d6cef7ba16dd92281c61c2f9fa9035b9043b3 was intentionally very careful to make easily-revertable change; and here you are starting a much wider cleanup. Please explain why we are certain that it's time to drop xmlrpc code. Line 9: Line 10: Change-Id: I6ab7d42efab98f23736d323b2b0b614a568b7112 -- To view, visit https://gerrit.ovirt.org/72740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ab7d42efab98f23736d323b2b0b614a568b7112 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
