From Dan Kenigsberg <[email protected]>:

Dan Kenigsberg has posted comments on this change.

Change subject: mailbox: Improve log when checksum fails
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/73074/3/lib/vdsm/storage/mailbox.py
File lib/vdsm/storage/mailbox.py:

PS3, Line 621: assert len(mailbox) == MAILBOX_SIZE
this addition is more than just log improvement. could you explain it in the 
commit message?


-- 
To view, visit https://gerrit.ovirt.org/73074
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c07435c8fe222d75b212956ef3e45c2b3510c71
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to