From Dan Kenigsberg <[email protected]>:

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Expose an existing bug in network restoration
......................................................................


net: Expose an existing bug in network restoration

This patch exposes a bug that exists in the network restoration flow
but was missed due to a missing step in one test and a missing
assertion.

testVolatileConfig test now simulates a reboot by deleting the running
config (which resides under /var/run/).
In addition, the assertNetworkDoesntExist assertion should also check
against the libvirt DB, assuring no leftovers are left there.

In the next patch this scenario will be solved, passing the failing
testVolatileConfig functional test.

Change-Id: Ifad0c04df9a36fba43ee678bbec4f3500b6a98ec
Signed-off-by: Edward Haas <[email protected]>
---
M lib/vdsm/network/libvirt.py
M tests/functional/networkTests.py
2 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/72313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifad0c04df9a36fba43ee678bbec4f3500b6a98ec
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to