From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: mailbox: Decrease the chance of checksum failures ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/73078/2//COMMIT_MSG Commit Message: Line 17: There is no way to write 4096 bytes atomically, so we cannot fix this Line 18: issue. But we can decrease the chance of the failure by doing one write Line 19: of 4096 bytes, instead of 8 writes of 512 bytes. There is still chance Line 20: of failure since writing on the remote storage is probably done using Line 21: 512 blocks, but the chance of reading incomplete write is much lower. I suspect that this may also improve performance on modern storage, where the sector size is 4096 ? Line 22: Line 23: Since both reading and writing was done using 512 bytes blocks, both Line 24: were modified to use 4096 block size. The SPM mailbox is already writing Line 25: replies using 4096 block size. -- To view, visit https://gerrit.ovirt.org/73078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e170d69437a9fb86bac7b65d6fcd48971375e99 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
