From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net: Drop blockingdhcp persistent config on read and write ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/73106/1//COMMIT_MSG Commit Message: PS1, Line 12: This behaviour attribute is supose to be volatile, not saved in any : persistent config. > That is an indirect implication of requesting the dhcp blocking behavior. I'm not sure I agree with Vdsm not caring if `ifup` is successful or not. As a user, I prefer synchronous APIs, that returns when dchp has finished, rather than "I got your request, but it might be bogus, ask me again some time in the future if things are fine". But for blockingdhcp Eddy is correct: on recovery we are ALWAYS waiting for dhcp response; we behave as if blockingdhcp=True regardless of what is in running config. So there is not reason to blockingdhcp in RunningConfig. -- To view, visit https://gerrit.ovirt.org/73106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ad81ba1d342db2ed560e95c79e5e96ca3da918c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
