From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: don't process devices that are gone ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/73463/2/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: Line 446: for device in libvirt_devices: Line 447: try: Line 448: name = device.name() Line 449: params = _process_device_params(device.XMLDesc(0)) Line 450: except libvirt.libvirtError: as in previous patch - can you limit the swallowed exception? Line 451: # The object still exists, but the underlying device is gone. For Line 452: # us, the device is also gone - ignore it. Line 453: continue Line 454: -- To view, visit https://gerrit.ovirt.org/73463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If73429d383a39061bb21ff11d08456998971edca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
