From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: network: report dpdk ports as nics ...................................................................... Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/73987/4/lib/vdsm/network/link/dpdk.py File lib/vdsm/network/link/dpdk.py: Line 71: Line 72: def link_info(dpdk_link): Line 73: """Returns a dictionary with the information of the link object.""" Line 74: info = {} Line 75: info['address'] = '02:00:00:00:00:0{}'.format(dpdk_link[-1:]) why support so few? dropping the leading 'dpdk', converting to int, and printing as hex would be slightly better. but do it in a special function, that would be easier to replace once we interact with the dpdk libs. Line 76: info['flags'] = '' Line 77: info['index'] = '' Line 78: info['mtu'] = '' Line 79: info['name'] = dpdk_link -- To view, visit https://gerrit.ovirt.org/73987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67b2083e9c6f032472fd75f6800c864083ffdef5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
