From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change.
Change subject: operation: Prepare for integrating CommandStream ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/74618/2/lib/vdsm/storage/operation.py File lib/vdsm/storage/operation.py: Line 125: self._proc = compat.CPopen(self._cmd, Line 126: cwd=self._cwd, Line 127: stdin=None, Line 128: stdout=subprocess.PIPE, Line 129: stderr=subprocess.PIPE) putting a call to CPopen under is a lock sounds risky. under the lock you should only change the state and release it quickly Line 130: self._state = RUNNING Line 131: Line 132: def _finalize(self, out, err): Line 133: """ -- To view, visit https://gerrit.ovirt.org/74618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff363e710fcdc5d6cd5843ca2239973c89a69dd3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchap...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org