From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has posted comments on this change.
Change subject: [RFC] qemuimg: Replace CommandStream with Command ...................................................................... Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/75009/6/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 230: def run(self): Line 231: out = bytearray() Line 232: for data in self._operation.irun(): Line 233: out += data Line 234: self._update_progress(out) but what about all those issues that leaded to deathSignal.. if the process is still stuck and vdsm moved on, it will stay alive. if vdsm will crash we will have zombies Line 235: Line 236: def abort(self): Line 237: """ Line 238: Aborts running operation by sending a termination signal to the -- To view, visit https://gerrit.ovirt.org/75009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb29860e7ec8ebc260f129de2066515cc3229743 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Denis Chaplygin <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
