From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: Set listen attribute as well as already set listen element ...................................................................... Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/75715/1//COMMIT_MSG Commit Message: PS1, Line 9: Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1437523 Please write as Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1437523 to integrate better with bugzilla. https://gerrit.ovirt.org/#/c/75715/1/vdsm/virt/vm_migrate_hook.py File vdsm/virt/vm_migrate_hook.py: Line 189: if net_api.ovs_bridge(target_display_network): Line 190: graphics_listen.attrib.pop('network', None) Line 191: graphics_listen.set('type', 'address') Line 192: graphics_listen.set('address', target_display_ip) Line 193: graphics.set('listen', target_display_ip) Thanks for your patch. http://libvirt.org/formatdomain.html#elementsGraphics says """ The address attribute is duplicated as listen attribute in graphics element for backward compatibility. If both are provided they must be equal. """ do we normally set the listen attribute on our VMs? It seems nicer to remove the old attribute. Line 194: else: Line 195: libvirt_network = net_api.netname_o2l(target_display_network) Line 196: graphics_listen.attrib.pop('address', None) Line 197: graphics_listen.set('type', 'network') -- To view, visit https://gerrit.ovirt.org/75715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe44ccfc70bba2ad9deabef3a33473725ab7fbbe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jonathan Dieter <jdie...@lesbg.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
