From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: Configure sasl2 libvirt to use scram-sha-1 ...................................................................... Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/76934/2/lib/vdsm/tool/configurators/passwd.py File lib/vdsm/tool/configurators/passwd.py: PS2, Line 44: ret == NO if one is MAYBE, we cannot say we the two are YES. if ret in (NO, MAYBE): Line 69: configure_passwd() Line 70: Line 71: Line 72: def removeConf(): Line 73: if passwd_isconfigured() == YES: don't we care about removing libvirt sasl conf? (maybe we don't, though it's not so pretty) Line 74: rc, out, err = commands.execCmd( Line 75: ( Line 76: str(_SASLPASSWD2), Line 77: '-p', Line 83: raise RuntimeError("Remove password failed: %s" % (err,)) Line 84: Line 85: Line 86: def configure_libvirt_sasl(): Line 87: with open(_SASL2_CONF, 'w') as f: we should say that this was auto-edited by vdsm version XYZ Line 88: f.writelines(['mech_list: scram-sha-1\n', Line 89: 'sasldb_path: %s' % (_LIBVIRT_SASLDB)]) Line 90: Line 91: -- To view, visit https://gerrit.ovirt.org/76934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I589e7de6df46ebb2f971701cf99a313b3c4a2f8e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
