From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in ipwrapper module ...................................................................... Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/77295/4/lib/vdsm/network/ipwrapper.py File lib/vdsm/network/ipwrapper.py: Line 613: def netns_delete(name): Line 614: _exec_cmd([_IP_BINARY.cmd, 'netns', 'delete', name]) Line 615: Line 616: Line 617: def netns_exec(netns_name, command): the async behavior is very odd, and worths a docstring alert Line 618: cmds = [_IP_BINARY.cmd, 'netns', 'exec', netns_name] + command Line 619: return Popen(cmds) Line 620: Line 621: -- To view, visit https://gerrit.ovirt.org/77295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50b4fe3eadb629673d3d45c255403f4fb35c5131 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
