From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: virt: add method to build device map from XML ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/77813/2/lib/vdsm/virt/vmdevices/common.py File lib/vdsm/virt/vmdevices/common.py: Line 197: try: Line 198: dev_type, dev_class = identify_from_xml_elem( Line 199: dev_elem Line 200: ) Line 201: except core.SkipDevice: I vote to pass unknown devices to libvirt, if possible. This would help us make Vdsm smaller, and more agile dvelopment, in case Engine wants to add a device without waiting for a fresh vdsm. Line 202: log.warning( Line 203: 'skipping unsupported device: %r %r', Line 204: dev_elem.tag, dev_alias Line 205: ) -- To view, visit https://gerrit.ovirt.org/77813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c8da1bbc2912f1e2112f348f8b2dafa811e8c7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
