Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-tool: add the sebool configuration module
......................................................................


Patch Set 2: Fails

(1 inline comment)

seems that I'm missing something basic.

....................................................
File vdsm-tool/seboolsetup.py
Line 39:     sebool_obj = seobject.booleanRecords()
Line 40:     sebool_status = sebool_obj.get_all()
Line 41: 
Line 42:     sebool_obj.start()
Line 43: 
to verify this patch, I've manually

 setsebool virt_use_nfs off

and install vdsm. The boolean was not turned on; how come do I have both

 >>> sebool_status["virt_use_nfs"]
 [1, 1, 1]
 $ getsebool virt_use_nfs
 virt_use_nfs --> off
Line 44:     for sebool_variable in VDSM_SEBOOL_LIST:
Line 45:         if status and not all(sebool_status[sebool_variable]):
Line 46:             sebool_obj.modify(sebool_variable, SEBOOL_ENABLED)
Line 47: 


--
To view, visit http://gerrit.ovirt.org/9362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01baf1c17f7cad2a0525b261be6b5ac648576252
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to